Skip to content

Upgrade to Vite 3#5005

Merged
Rich-Harris merged 51 commits intomasterfrom
vite-3
Jul 14, 2022
Merged

Upgrade to Vite 3#5005
Rich-Harris merged 51 commits intomasterfrom
vite-3

Conversation

@benmccann
Copy link
Member

@benmccann benmccann commented May 20, 2022

Announcement blog post: https://vitejs.dev/blog/announcing-vite3.html

Some changes noticeable for SvelteKit:

  • relative base support (Dynamic basepath #595)
  • default port changed to 5173 in development mode
  • fixStacktrace now defaults to false
  • We can now set appType: 'custom' so that HTML middlewares are not added and we no longer have to remove many of them

v3 also added a new hook configurePreviewServer that has been backported to 2.9 and already leveraged in SvelteKit master which allowed us to switch to the vite CLI

@changeset-bot
Copy link

changeset-bot bot commented May 20, 2022

⚠️ No Changeset found

Latest commit: 293d564

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member

what do 'disable spa' and 'configurePreviewServer' mean?

@Rich-Harris
Copy link
Member

i think this might work

[RON HOWARD VOICE] it did not work

Rich-Harris and others added 15 commits July 13, 2022 19:02
This reverts commit 9e2d017.
)

* fix: move create-svelte test working dir out of pnpm workspae

* fix: copy-paste error, adapter-auto override

* fix: readd check command

* fix: ensure that create-svelte tests generate test apps outside our main pnpm workspace

* fix format

* fix: readd --no-frozen-lockfile to override pnpm default when CI is true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants