Expose caches to Cloudflare adapter through Platform#5081
Merged
Rich-Harris merged 2 commits intosveltejs:masterfrom Jul 6, 2022
Merged
Expose caches to Cloudflare adapter through Platform#5081Rich-Harris merged 2 commits intosveltejs:masterfrom
caches to Cloudflare adapter through Platform#5081Rich-Harris merged 2 commits intosveltejs:masterfrom
Conversation
🦋 Changeset detectedLatest commit: 5ca08b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benmccann
approved these changes
Jun 24, 2022
Member
benmccann
left a comment
There was a problem hiding this comment.
lgtm, but I'm not the most familiar with Cloudflare, so will leave this for others to review as well
| + waitUntil(promise: Promise<any>): void; | ||
| + } | ||
| + }; | ||
| + caches: CacheStorage & { default: Cache } |
Member
There was a problem hiding this comment.
I wonder if we should show these in alphabetical order?
Contributor
Author
There was a problem hiding this comment.
I put caches at the bottom because it is the least likely to be used.
Rich-Harris
approved these changes
Jul 6, 2022
Member
|
thank you! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exposes Cloudflare's Worker Cache API as
cachesin theplatformobject. This allows hooks to do elaborate caching, for example, I use the Cache API to cache certain pages based on request cookies.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0