Update adapter entrypoint typings to be NodeNext/ESNext-compatible.#5111
Merged
Rich-Harris merged 3 commits intosveltejs:masterfrom May 30, 2022
adam-coster:fix/5110
Merged
Update adapter entrypoint typings to be NodeNext/ESNext-compatible.#5111Rich-Harris merged 3 commits intosveltejs:masterfrom adam-coster:fix/5110
Rich-Harris merged 3 commits intosveltejs:masterfrom
adam-coster:fix/5110
Conversation
🦋 Changeset detectedLatest commit: 9a0b1ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
approved these changes
May 30, 2022
Member
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #5110, the entry
index.d.tsfiles of the adapters all use a node-resolution-compatible export syntax like this:However, all of these packages use ESM (instead of CommonJS) so they can instead use:
Making this change resolves a Typescript 4.7+ error where
import adapter from '@sveltejs/adapter-auto';throws a compiler error when thetsconfig.jsonis configured withmoduleResolutionset toNodeNextorESNext.To make this change, all of the
index.jsfiles that import these types have to have their JSDoc import statements changed to explicitly grab thedefaultexport. E.g./** @type {import('.')} **/➡️/** @type {import('.').default} **/.Since these packages are already modules these typings are more technically correct, though it's possible that this change will result in new Typescript errors for some compiler configurations. With Typescript 4.8 (dev), I can confirm that this change results in no errors with either of the following
tsconfigconfigurations:Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0