Merged
Conversation
benmccann
approved these changes
Mar 19, 2021
Member
benmccann
left a comment
benmccann
left a comment
There was a problem hiding this comment.
I like this API more. Hopefully this still works with "type": "module" in the user's package.json. I think it should
Member
Author
|
It will work, yeah, you just can't go the other way (a CommonJS file can't import ESM) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #439. Slightly unfortunate that this requires turning the adapters back into CommonJS packages, but I think this is a fundamentally better design.