Move compress inside kit#5822
Merged
Rich-Harris merged 6 commits intosveltejs:masterfrom Aug 6, 2022
enBonnet:move-compress-inside-kit
Merged
Move compress inside kit#5822Rich-Harris merged 6 commits intosveltejs:masterfrom enBonnet:move-compress-inside-kit
Rich-Harris merged 6 commits intosveltejs:masterfrom
enBonnet:move-compress-inside-kit
Conversation
🦋 Changeset detectedLatest commit: 9f8dd3f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benmccann
reviewed
Aug 5, 2022
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Rich-Harris
reviewed
Aug 6, 2022
Rich-Harris
approved these changes
Aug 6, 2022
Member
|
Thank you! This is way better |
Contributor
Author
|
Glad to help, lets keep pushing to 1.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3796
This PR move
compressinsidebuilderto avoid having it duplicate insideadapter-nodeandadapter-static.HEADS UP!
We're about to embark on a significant redesign that will touch many parts of the codebase. Until that work is finished, PRs are very likely to result in merge conflicts, and will likely be ignored until the redesign work is complete (by which time they will likely be stale). Please consider delaying your PR until then.
Thank you for understanding!
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0