-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix: Silently skip prefetching external URLs instead of warning #6518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Silently skip prefetching external URLs instead of warning #6518
Conversation
🦋 Changeset detectedLatest commit: 40824bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thank you! I think the error is useful in the case where you're programmatically prefetching. What about changing the behaviour of |
Thanks for the feedback! That sounds like a good way forward. When app devs call I'll explore this further in the coming days. This would be a fun contribution to make! |
For automatic prefetching with `data-sveltekit-prefetc`, silently return early like before.
✅ Deploy Preview for kit-demo ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Update:Prefetching never happens for external URLs. The difference is that programmatic calls to Remaning TODOs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI succeeded and I don't get these test failures locally, so I'd say we are good - thank you 👍
Fix #6463 by automatically skipping prefetching of external URLs instead of warning app developers. This aligns with how Next.js solves the same problem.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0