exclude Node 17.x as supported version#8174
Conversation
|
@Conduitry is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: ac90f0a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I really can't tell what all these test and deployment failures are about. I don't see how they could be related to this change. |
|
(I approved because I think Node 17 being a non-LTS line and unsupported at this point is a good-enough reason to make this change right now when 1.0 is so fresh still; it will probably break right away for anyone using it anyway, as the issue shows) |
|
Question about Cloudflare – right now they ask for 17 for Pages projects, wondering what the impact there might be |
|
That's annoying. Thanks. I've opened a PR cloudflare/cloudflare-docs#7043 |
|
I'm also not sure if anything above 17 is available, last time I tried 18 it wasn't. Let me try a build now ... Nope: edit: their container is a bit weird (Node 12 by default, PHP 5.6?), and they know this, but it's taking a while for them to update everything in it, so this may be a good prod to make that happen |
|
Do you know what version of Node 16 you get if you specify |
|
Let's see ... 16.19.0. I can go around to my existing Pages projects and switch everything to 16, just in case it takes a while for Flare to get on it. When you ask for 17 you get 17.9.1, fyi |
* explicitly exclude Node 17.x in supported versions * add changeset
Closes #8173. The
>=16.14range also includes Node 17, which (apparently at least in some versions) doesn't support the three-argument version ofutil.inspect.custom. People shouldn't be using Node 17 anyway. I think we can make this change as a fix rather than as a breaking change.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0