fix: change Vite config type to work with Vitest options#8871
fix: change Vite config type to work with Vitest options#8871Rich-Harris merged 1 commit intosveltejs:masterfrom teemingc:fix-vite-config-type-with-vitest
Conversation
dummdidumm
left a comment
There was a problem hiding this comment.
Is this a breaking change since it changes the shape of the vite config? If so, we should release it together with the other breaking change (and further breaking changes possibly coming out of the svelte package discussion)
As in how the config is exported? (changed from exporting the constant to directly exporting the method output). I'm not sure if it's breaking. It still uses the vite |
|
It's more along the lines of potential downstream projects like |
|
approved, but will hold off merging till we get clarity around |
|
Svelte Add is fine with |
closes #8768
As suggested by Rich and Dominik, this changes all
vite.configtemplates to:defineConfiginstead of type annotations.defineConfigfromvitestif the project includes vitest.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.