fix: serve_prerendered breaks on node http server#8890
Merged
Rich-Harris merged 5 commits intomasterfrom Feb 6, 2023
Merged
Conversation
dummdidumm
reviewed
Feb 6, 2023
| "prepublishOnly": "pnpm build" | ||
| }, | ||
| "devDependencies": { | ||
| "@polka/url": "^1.0.0-next.21", |
Member
There was a problem hiding this comment.
Doesn't this need to be a regular dependency if we're using it in the code the user gets?
Contributor
Author
There was a problem hiding this comment.
No, because it gets bundled.
Rich-Harris
approved these changes
Feb 6, 2023
Merged
Member
|
oops! thanks for the fix. re tests — something i've been meaning to get round to for the longest time is:
for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8888
Tests have been disabled for adapter-node since #2931, so didn't add any in this one. Will look into re-enabling.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.