feat: Add a speedier script tag for prerendered redirects#9911
feat: Add a speedier script tag for prerendered redirects#9911Rich-Harris merged 8 commits intomasterfrom
Conversation
🦋 Changeset detectedLatest commit: b1af08e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Looks like I missed a few tests; will have to go back and fix 'em |
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Rich-Harris
left a comment
There was a problem hiding this comment.
i feel good about the encoding, but this has historically been a blind spot of mine so i'd be happy to wait for others to weigh in (@Conduitry is particularly adept at heading off string encoding bugs)
|
Hm. What specifically are we trying to handle by doing Since Can we instead do a straight string escaping thing of |
|
Thanks @Conduitry -- the reason we were doing a decode/encode is to avoid double-encoding. That being said, I think you're right about just string-escaping it. I'm not going to have time to do this today or tomorrow, so I'll probably get it done on Monday. |
|
@Conduitry -- mind taking a look now that we're using |
Co-authored-by: Conduitry <git@chor.date>
Closes #9907.
TODO:
(I also deleted some empty +page.svelte files, which used to be required but now are not)
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.