Skip to content

svelte2tsx to handle @const#1072

Merged
dummdidumm merged 11 commits intosveltejs:masterfrom
tanhauhau:tanhauhau/gh-1067
Jan 13, 2022
Merged

svelte2tsx to handle @const#1072
dummdidumm merged 11 commits intosveltejs:masterfrom
tanhauhau:tanhauhau/gh-1067

Conversation

@tanhauhau
Copy link
Member

Fixes #1067

@tanhauhau tanhauhau force-pushed the tanhauhau/gh-1067 branch from f611083 to 3d8db45 Compare June 21, 2021 07:42
@dummdidumm
Copy link
Member

Oh wow, thank you very much for this 🎉 From a quick glance this looks good.

Notes to self on what to check:

  • how it behaves when there are #if blocks in the parent, possibly with conflicting names
  • quick check on rename/diagnostics/go to definition work and possibly adding tests, at least for the diagnostics

@dummdidumm dummdidumm merged commit 7c7f9d7 into sveltejs:master Jan 13, 2022
@tanhauhau tanhauhau deleted the tanhauhau/gh-1067 branch January 13, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for @const feature

2 participants