fix: align default tsconfig "include" logic with tsc/tsserver - #3110
Open
jasonlyu123 wants to merge 3 commits into
Open
fix: align default tsconfig "include" logic with tsc/tsserver#3110jasonlyu123 wants to merge 3 commits into
jasonlyu123 wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: f9f893a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3108
Two fixes in this PR. One is to align the default tsconfig "include" logic with tsc/tsserver. While debugging #3108, I found that TypeScript actually excludes "dot folders" and node_modules from the
**/*pattern. The problem that triggers the "large amount of files" warning is mainly our project files update logic.The other fix is about the reduced mode; the problem is that we don't return any files in
getScriptFileNames. Thus, the language service throws an error if any features were requested with the file.