fix: hide generated template functions from document symbols - #3114
Open
colecrouter wants to merge 1 commit into
Open
fix: hide generated template functions from document symbols#3114colecrouter wants to merge 1 commit into
colecrouter wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 2dbb1a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
colecrouter
changed the title
Contributor
Author
jasonlyu123
reviewed
Sep 3, 2026
| // actually wrote. | ||
| if ( | ||
| !isInScript(symbol.location.range.start, document) && | ||
| !isInFunctionExpression(tsDoc.svelteNodeAt(symbol.location.range.start)) |
Member
There was a problem hiding this comment.
Instead of finding the exact node, then walk up the AST tree. It'll be slightly more performant to walk down the AST until a function expression or a snippet block where the document symbol position is inside the start tag({#snippet ...})
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multi-line snippets currently generate garbage output. Detect generated anonymous functions by first checking if they are in a template & checking if they were written by the user, then skip those symbols.
Before:
After:
Tests cases include parametrized and non-parametrized snippets, as well as user-defined anonymous functions.