Skip to content

Handle ERR_PACKAGE_PATH_NOT_EXPORTED gracefully #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ctavan wants to merge 1 commit into from
Closed

Handle ERR_PACKAGE_PATH_NOT_EXPORTED gracefully #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ function tryResolve(pkg, importer) {
return relative.resolve(pkg, importer);
} catch (err) {
if (err.code === 'MODULE_NOT_FOUND') return null;
if (err.code === 'ERR_PACKAGE_PATH_NOT_EXPORTED') {
console.warn(`WARNING: Could not read svelte config from ${pkg}. Reason: ${err.message}`);
return null;
}
throw err;
}
}
Expand Down
Empty file added test/node_modules/esm-module-without-svelte-config/index.js
View file
Open in desktop
Empty file.
6 changes: 6 additions & 0 deletions test/node_modules/esm-module-without-svelte-config/package.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Empty file added test/node_modules/esm-widget/index.js
View file
Open in desktop
Empty file.
8 changes: 8 additions & 0 deletions test/node_modules/esm-widget/package.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions test/node_modules/esm-widget/src/Widget.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 16 additions & 0 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,22 @@ describe('rollup-plugin-svelte', () => {
);
});

it('ignores esm module not exporting package.json', () => {
const { resolveId } = plugin();
assert.equal(
resolveId('esm-module-without-svelte-config', path.resolve('test/foo/main.js')),
null
);
});

it('resolves esm module exporting package.json', () => {
const { resolveId } = plugin();
assert.equal(
resolveId('esm-widget', path.resolve('test/foo/main.js')),
path.resolve('test/node_modules/esm-widget/src/Widget.html')
);
});

it('ignores virtual modules', () => {
const { resolveId } = plugin();
assert.equal(
Expand Down