Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Live Reload Not Working On Webpack Branch #764

Closed

Description

@jeremyjh

It works fine with Rollup, but on Webpack the page gets rebuilt on change but then you have to manually refresh the browser if you want to load the changes.

Activity

  1. Aias commented on Jun 30, 2019

    @Aias

    Also seeing this, with the following error logged to the console:

    Uncaught TypeError: Cannot read property 'status' of undefined
        at check (sapper-dev-client.js:6)
        at EventSource.source.onmessage (sapper-dev-client.js:37)
    
  2. jacobstanley commented on Jul 17, 2019

    @jacobstanley

    I was also having this problem on webpack (when it worked just fine with rollup), but I eventually found that if I manually disabled hot module reloading then sapper will enable live reloading instead and everything seems to work as expected.

    So I have changed yarn dev to execute sapper dev --no-hot.

  3. samuelhnrq commented on Sep 3, 2019

    @samuelhnrq

    Well I've first found this same issue in the template repo sveltejs/sapper-template#153 but I believe the issue seems to be with sapper internal code itself, and no one seems to actually try to fix he issue instead of simply disabling hot reloading...

  4. akvadrako commented on Feb 20, 2020

    @akvadrako
  5. AlbertMarashi commented on Apr 14, 2020

    @AlbertMarashi
  6. samuelhnrq commented on Aug 20, 2020

    @samuelhnrq

    Well very long since I last visited this issue but there is even webpack 5 now...

  7. antony commented on Aug 20, 2020

    @antony
    Member

    We're more likely to drop webpack support than implement webpack 5 at this point, so I wouldn't hold your breath.

  8. antony commented on Aug 20, 2020

    @antony
    Member

    nuxt.js is another excellent option for building PWAs

  9. samuelhnrq commented on Oct 12, 2020

    @samuelhnrq

    Well, as it stands the webpack implementation is simply broken. Shouldn't it be removed from the README.md?

  10. antony commented on Oct 12, 2020

    @antony
    Member

    as an alternative, somebody from the community who has expertise in webpack could help us fix it, or migrate to webpack 5 perhaps?

  11. ehrencrona commented on Oct 12, 2020

    @ehrencrona
    Contributor

    This may be somewhat off-topic, but what is the benefit of offering two different bundlers? If there's a compelling reason to keep offering webpack I'd be happy to look into this, but if we could simplify things at no cost by just dropping webpack it's probably not worth the effort.

  12. benmccann commented on Oct 12, 2020

    @benmccann
    Member

    There is a PR pending for webpack 5 support in svelte-loader: sveltejs/svelte-loader#136

  13. benmccann commented on Mar 16, 2021

    @benmccann
    Member

    SvelteKit supports live reload and is where all our development focus is currently, so I'd recommend using that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions