This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Fix CSS code splitting with Rollup 2 #1306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antony
approved these changes
Jul 8, 2020
This was referenced Jul 8, 2020
lukeed
approved these changes
Jul 29, 2020
habibrosyad
pushed a commit
to habibrosyad/sapper
that referenced
this pull request
Aug 4, 2020
trmcnvn
pushed a commit
to metafy-gg/sapper
that referenced
this pull request
Aug 15, 2020
benmccann
referenced
this pull request
in metered/sapper
Aug 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue described in sveltejs/sapper-template#233, which is that CSS modules get tree shaken out in Rollup 2
Thanks to @habibrosyad for the bug report and also testing and confirming that this fix works both with the latest Rollup release and older Rollup releases