Preload assets in Rollup apps - fixes #408 #440
Conversation
| } else { | ||
| Object.keys(chunk.modules).forEach((module: string) => { | ||
| if (!module.startsWith(routes_dir)) return; | ||
| if (/\.css$/.test(module)) return; |
There was a problem hiding this comment.
Not sure whether these checks are the best way to detect whether a chunk is a page.
|
Gah, sorry for letting this PR fester. Tried to merge it just now but master has diverged too far; had a quick go at resolving the conflict but was a bit of a rabbit hole. Might be easier for us to take another run at this after the Svelte 3 changes are in |
|
@nsivertsen is this something you'd still be interested in pursuing? I know it's been awhile, but any chance you'd be able to rebase it? |
|
@benmccann hi! I would be, however I'm quite swamped at the moment so it would be a couple weeks before I could look into it. If you have time sooner, feel free to take a stab at it! As both Sapper and Rollup have gone through a fair amount of changes in the meantime, there might be a better way of doing this, so it could be worth looking at this with fresh eyes. |
|
No worries. We can wait for whenever you get a chance |
|
I've sent #1269 which is rebased against master and handles all transitive JS dependencies as well as CSS files |
|
Closing in favour of #1269 |
I'm not sure if the way I'm testing whether a chunk is a page is 100% right, see
RollupResult.ts, lines 47-48.Fixes #408