This repository was archived by the owner on Jan 11, 2023. It is now read-only.
include css depended upon by entry point, even if also depended on by a lazily-loaded component #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a lazily-loaded component
|
I tried running Sapper from |
|
@arggh huh. that's with latest Rollup etc? |
|
oh, wait, I forgot I ran into a similar thing earlier today — d'oh. Can you try again please? |
|
@Rich-Harris Works now! |
|
Oddly enough I couldn't quite figure out how to make a failing test for this, even though I managed to reproduce the bug in a separate project. Rather than wrestle with it all day I've released 0.23.2 |
This was referenced Aug 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug whereby CSS depended upon by the entry point (which statically depends on
src/routes/_layout.htmlif it exists, along withsrc/routes/index.htmlandsrc/routes/_error.html) would be omitted if it is also depended upon by a lazily-loaded chunk.The code is a bit woolly, and it could use some tests, so I'm just going to leave it here for the moment