Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Add noscroll option to goto #613

Closed
wants to merge 2 commits into from
Closed

Add noscroll option to goto #613

wants to merge 2 commits into from

Conversation

cbenz
Copy link
Contributor

@cbenz cbenz commented Mar 18, 2019

Started this PR to implement #584

@cbenz cbenz changed the title WIP: Add noscroll option to goto Add noscroll option to goto Mar 18, 2019
@cbenz
Copy link
Contributor Author

cbenz commented Apr 13, 2019

I think the feature is ready to merge.

I added a test, but I don't understand the error:

  1) scroll
       preserves scroll when noscroll is passed to goto:
     Error: No node found for selector: button
      at assert (node_modules\puppeteer\lib\helper.js:229:11)
      at DOMWorld.click (node_modules\puppeteer\lib\DOMWorld.js:359:5)
      at processTicksAndRejections (internal/process/task_queues.js:86:5)
    -- ASYNC --
      at Frame.<anonymous> (node_modules\puppeteer\lib\helper.js:108:27)
      at Page.click (node_modules\puppeteer\lib\Page.js:1021:29)
      at Context.it (test\apps\scroll\test.ts:101:14)
      at processTicksAndRejections (internal/process/task_queues.js:86:5)

I think I need some help to fix it.

@cbenz cbenz marked this pull request as ready for review April 13, 2019 11:56
@antony antony self-assigned this Jul 15, 2020
@antony
Copy link
Member

antony commented Jul 15, 2020

Closing in favour of #1320 (review)

@antony antony closed this Jul 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants