Allow the user to ignore warnings in the script tag

[paoloricciuti]

Describe the bug

As per #11818 (comment) currently there's no way to silence a warning in the script tag.

The user should be able to use the same svelte-ignore comments as in the template

Reproduction

REPL

Logs

No response

System Info

repl

Severity

annoyance

[Conduitry]

Hm. I'm not sure how we'd want something like this to interact with, for example, ignore comments in ESLint, where I think we're also surfacing these warnings. Presumably a comment like the one proposed in this issue would prevent the compiler from emitting the warning, which would prevent ESLint from knowing about it and reporting it. Would it be confusing to have two ways of doing the same thing?

[dummdidumm]

// svelte-ignore works in Svelte 4, so this is a regression in Svelte 5 that needs fixing.

[Conduitry]

Oh, I didn't realize this existed in Svelte 4 already. I guess I'm not going to worry then about the two different ways of ignoring warnings.

[paoloricciuti]

Uh actually: some warning can actually be silenced in the script...there are two or three that can't because they are raised after the analysis walked the whole ast based on the bindings.

[dummdidumm]

Oh right, yeah some are not silenceable right now. Not sure if worth to find workarounds for all of them

[paoloricciuti]

Oh right, yeah some are not silenceable right now. Not sure if worth to find workarounds for all of them

Yeah i was kinda trying to find a solution but it's very difficult because the check needs to happen after the walk but after the ignore_stack is only filled during the walk.

I tried to move the ignore_pop and ignore_stack management in the scope but sometimes the code to ignore is not a binding and it's a function call. I wonder if is worth trying to change the logic for the ignore_stack and instead of pushing into an array it literally does the check looping over parent.children inside the warning function itself.

I'll try again later

[paoloricciuti]

What if we attach the "ignore information" to node itself? Then the warning function can just check the ignore from the node itself.

I remember the will to remove metadata from the nodes tho right?

[dummdidumm]

It was on the node itself for some time but that had drawbacks, too, in some locations. I think the most practical solution is to keep the current system and add one-off hacks/fixes to those specific warnings - and probably also not all of them. I don't think you want to silence them all (i.e. it makes no sense to ignore some of these anyway)

[paoloricciuti]

It was on the node itself for some time but that had drawbacks, too, in some locations. I think the most practical solution is to keep the current system and add one-off hacks/fixes to those specific warnings - and probably also not all of them. I don't think you want to silence them all (i.e. it makes no sense to ignore some of these anyway)

I took a shot with an idea that i had...let me know how bad it is 😄

[nickolasgregory]

Sorry to comment on a closed issue.
Is there any chance this could be made to work in the docblock with my comments, @type etc.. ala;

	/**
	 * Not state related
	 * @type {object}
	 * @svelte-ignore non_reactive_update
	 */
	let a = {}

Rather than appending a separate line for // svelte-ignore non_reactive_update