Skip to content

fix: allow for more svelte-ignore to work#11833

Merged
dummdidumm merged 4 commits into
sveltejs:mainfrom
paoloricciuti:fix-svelte-ignore-scripts
May 31, 2024
Merged

fix: allow for more svelte-ignore to work#11833
dummdidumm merged 4 commits into
sveltejs:mainfrom
paoloricciuti:fix-svelte-ignore-scripts

Conversation

@paoloricciuti

Copy link
Copy Markdown
Member

Svelte 5 rewrite

Closes #11822

I had this idea of using a WeakMap to keep the ignore list for every node...it works well except for store_rune_conflict because that's invoked even before the ast is walked. But i also think it make no sense to silence that warning.

I don't know if this is good solution or not but i just leave it out there, if it's not desired obviously feel free to close. 😄

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot

changeset-bot Bot commented May 29, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 505a381

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm dummdidumm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow the user to ignore warnings in the script tag

2 participants