Skip to content

Addition assignment operator (+=) broken #12174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ChristopheCorbalan opened this issue Jun 25, 2024 · 0 comments · Fixed by #12175
Closed

Addition assignment operator (+=) broken #12174

ChristopheCorbalan opened this issue Jun 25, 2024 · 0 comments · Fixed by #12175
Assignees
@dummdidumm
Labels
bug

Comments

@ChristopheCorbalan
Copy link

ChristopheCorbalan commented Jun 25, 2024 •
edited
Loading

Describe the bug

It seems like [email protected] introduced the bug.

Whenever I create a state object and that I want to increment a number with the addition assignment operator it gets replaced by "++".

Input:
input

Output:
output

Reproduction

REPL

Logs

No response

System Info

System:
    OS: macOS 14.4
    CPU: (12) arm64 Apple M2 Max
    Memory: 8.76 GB / 32.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.6.1 - ~/.nvm/versions/node/v20.6.1/bin/node
    npm: 10.1.0 - ~/.nvm/versions/node/v20.6.1/bin/npm
    bun: 1.1.13 - ~/.bun/bin/bun
  Browsers:
    Chrome: 126.0.6478.114
    Firefox Nightly: 128.0a1
    Safari: 17.4

Severity

blocking an upgrade
@dummdidumm dummdidumm added the bug label Jun 25, 2024
@dummdidumm dummdidumm self-assigned this Jun 25, 2024
dummdidumm added a commit that referenced this issue Jun 25, 2024
@dummdidumm
fix: correctly serialize object assignment expressions
07662d4 
fixes #12174
#12109 didn't take into account actual object assignments and couldn't differentiate them from our "fake" assignments, this fixes that
@dummdidumm dummdidumm mentioned this issue Jun 25, 2024
Merged
5 tasks
FoHoOV pushed a commit to FoHoOV/svelte that referenced this issue Jun 27, 2024
@dummdidumm @FoHoOV
fix: correctly serialize object assignment expressions (sveltejs#12175)
b98c2dd 
fixes sveltejs#12174
sveltejs#12109 didn't take into account actual object assignments and couldn't differentiate them from our "fake" assignments, this fixes that
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dummdidumm dummdidumm

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: correctly serialize object assignment expressions sveltejs/svelte
2 participants
@dummdidumm @ChristopheCorbalan