Skip to content

Change detected language to TypeScript #4284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
baslr opened this issue Jan 18, 2020 · 5 comments
Closed

Change detected language to TypeScript #4284

baslr opened this issue Jan 18, 2020 · 5 comments
Labels

Comments

@baslr
Copy link
Contributor

baslr commented Jan 18, 2020

Is your feature request related to a problem? Please describe.
Svelte is detected as a JavaScript project by github linguist.
I sugest to change it to TypeScript.

Describe the solution you'd like
There are several solutions: https://github.com/github/linguist#overrides

image

@AnatoleLucet
Copy link

AnatoleLucet commented Jan 18, 2020

@baslr can you please develop on the "why"?

@baslr
Copy link
Contributor Author

baslr commented Jan 18, 2020

It does not show up on the search https://github.com/search?l=TypeScript&p=2&q=stars%3A%3E10000&type=Repositories
The meta data about a repository should be right.

@AnatoleLucet
Copy link

That's not a bad idea since Svelte is mainly written in Typescript.

@Conduitry Conduitry added the meta label Jan 19, 2020
@baslr
Copy link
Contributor Author

baslr commented Jan 22, 2020

@AnatoleLucet should I open a PR?

@AnatoleLucet
Copy link

Well yes, I guess. Since Conduitry added the 'meta' label to this issue - I'm guessing he's kind of agreeing with this Idea, so your PR will probably be merged.

baslr added a commit to baslr/svelte that referenced this issue Jan 11, 2021
help linguist to detect typescript as the programming language.
Solves issue sveltejs#4284
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants