Skip to content

When using both index and Id in each-blocks and sorting the array, sometimes the ordinal numbers are not correct #6543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jet-Li-Glow opened this issue Jul 20, 2021 · 2 comments

Comments

@Jet-Li-Glow
Copy link

Describe the bug

In the official example animations, each TODO item is added with a serial number and randomly sorted, and the serial number will be confused after multiple sorting

Reproduction

<script> import { quintOut } from 'svelte/easing'; import { crossfade } from 'svelte/transition'; import { flip } from 'svelte/animate'; const [send, receive] = crossfade({ fallback(node, params) { const style = getComputedStyle(node); const transform = style.transform === 'none' ? '' : style.transform; return { duration: 600, easing: quintOut, css: t => ` transform: ${transform} scale(${t}); opacity: ${t} ` }; } }); let todos = [ { id: 1, done: false, description: 'write some docs' }, { id: 2, done: false, description: 'start writing JSConf talk' }, { id: 3, done: true, description: 'buy some milk' }, { id: 4, done: false, description: 'mow the lawn' }, { id: 5, done: false, description: 'feed the turtle' }, { id: 6, done: false, description: 'fix some bugs' }, ]; let uid = todos.length + 1; function add(input) { const todo = { id: uid++, done: false, description: input.value }; todos = [todo, ...todos]; input.value = ''; } function remove(todo) { todos = todos.filter(t => t !== todo); } function sortTodo() { console.log('-- sort --') todos = todos.sort((a, b) => {return Math.random() - 0.5}); } </script> <style> .new-todo { font-size: 1.4em; width: 100%; margin: 2em 0 1em 0; } .board { max-width: 36em; margin: 0 auto; } .left, .right { float: left; width: 50%; padding: 0 1em 0 0; box-sizing: border-box; } h2 { font-size: 2em; font-weight: 200; user-select: none; } label { top: 0; left: 0; display: block; font-size: 1em; line-height: 1; padding: 0.5em; margin: 0 auto 0.5em auto; border-radius: 2px; background-color: #eee; user-select: none; } input { margin: 0 } .right label { background-color: rgb(180,240,100); } .box button { float: right; height: 1em; box-sizing: border-box; padding: 0 0.5em; line-height: 1; background-color: transparent; border: none; color: rgb(170,30,30); opacity: 0; transition: opacity 0.2s; } label:hover button { opacity: 1; } </style>
<div><button on:click="{sortTodo}">排  序</button></div>

<div class='left box'>
	<h2>todo</h2>
	{#each todos.filter(t => !t.done) as todo, i (todo.id)}
		<label
			in:receive="{{key: todo.id}}"
			out:send="{{key: todo.id}}"
			animate:flip
		>
			<span>{i + 1}</span>
			<input type=checkbox bind:checked={todo.done}>
			{todo.description}
			<button on:click="{() => remove(todo)}">x</button>
		</label>
	{/each}
</div>

<div class='right box'>
	<h2>done</h2>
	{#each todos.filter(t => t.done) as todo, i (todo.id)}
		<label
			in:receive="{{key: todo.id}}"
			out:send="{{key: todo.id}}"
			animate:flip
		>
			<span>{i + 1}</span>
			<input type=checkbox bind:checked={todo.done}>
			{todo.description}
			<button on:click="{() => remove(todo)}">x</button>
		</label>
	{/each}
</div>

Logs

No response

System Info

Windows 7
360浏览器

Severity

annoyance

@Jet-Li-Glow
Copy link
Author

sortbug

@dummdidumm
Copy link
Member

Duplicate of #6444, fixed with 3.39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants