Skip to content

fix: ensure top level snippets are defined when binding to component prop #11104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

dummdidumm
Copy link
Member

...by hoisting top level snippets out of the binding loop in ssr mode fixes #11086

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

…prop

...by hoisting top level snippets out of the binding loop in ssr mode
fixes #11086
Copy link

changeset-bot bot commented Apr 9, 2024

🦋 Changeset detected

Latest commit: 1391bed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit 27891cb into main Apr 10, 2024
@Rich-Harris Rich-Harris deleted the snippet-loop-hoist branch April 10, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: Bug - ReferenceError occurs when defining a snippet inside a script along with bind:value in SSR mode.
3 participants