Skip to content

fix: Abort outro when intro starts #12321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 11, 2024
Merged

fix: Abort outro when intro starts #12321

merged 3 commits into from
Jul 11, 2024

Conversation

Fruup
Copy link
Contributor

@Fruup Fruup commented Jul 6, 2024

Fixes #12319.

Currently, if an intro animation starts before an outro is finished, the outro overlaps the intro and leaves the element in an unwanted state (see the PR for a video). I think the outro should always be cancelled if an intro starts.

Reproduction

Write this into playgrounds/demo/src/main.svelte...

<!-- file: playgrounds/demo/src/main.svelte -->

<script lang="ts">
  import { fly } from 'svelte/transition';

  let state = $state(0);
</script>

<button onclick={() => state++}>{state}</button>

{#if state % 2 === 0}
  <h2 transition:fly={{ duration: 1000, x: 100 }}>Hello World!</h2>
{/if}

then...

cd playgrounds/demo
pnpm dev

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jul 6, 2024

🦋 Changeset detected

Latest commit: f0c2b45

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. I tried it out locally and it does indeed improve the behaviour as mentioned.

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you — we'll need a test for this before we can merge it. will try and add one later if no-one beats me to it

@dummdidumm
Copy link
Member

Adjusted an existing test which turned out to test nothing since Svelte 4, because we changed transitions to be local by default back then; and because it was nested inside an each block it did nothing.

@dummdidumm dummdidumm merged commit fd7b950 into sveltejs:main Jul 11, 2024
7 of 9 checks passed
@Fruup Fruup deleted the fix/12319 branch July 11, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: Outro animation is not cancelled and overlaps with intro
4 participants