-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
fix: Abort outro when intro starts #12321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…eltejs#12319 - abort outro animation when intro starts
🦋 Changeset detectedLatest commit: f0c2b45 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. I tried it out locally and it does indeed improve the behaviour as mentioned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you — we'll need a test for this before we can merge it. will try and add one later if no-one beats me to it
… 4 because of local-by-default)
Adjusted an existing test which turned out to test nothing since Svelte 4, because we changed transitions to be local by default back then; and because it was nested inside an each block it did nothing. |
Fixes #12319.
Currently, if an intro animation starts before an outro is finished, the outro overlaps the intro and leaves the element in an unwanted state (see the PR for a video). I think the outro should always be cancelled if an intro starts.
Reproduction
Write this into
playgrounds/demo/src/main.svelte
...then...
cd playgrounds/demo pnpm dev
Svelte 5 rewrite
Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (
main
).If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is
svelte-4
and notmain
.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint