Skip to content

fix: properly update store values #12562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix: properly update store values #12562

merged 1 commit into from
Jul 23, 2024

Conversation

dummdidumm
Copy link
Member

We need to extend the "don't use set on first run" logic to the falsy branch aswell

Fixes #12558

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

We need to extend the "don't use `set` on first run" logic to the falsy branch aswell

Fixes #12558
Copy link

changeset-bot bot commented Jul 23, 2024

🦋 Changeset detected

Latest commit: bc171a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit e2b75d1 into main Jul 23, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the store-falsy-value-fix branch July 23, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting a store to undefined and then trying to use it in a rune throws state_unsafe_mutation error
2 participants