-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
breaking: avoid flushing queued updates on mount/hydrate #12602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking: avoid flushing queued updates on mount/hydrate #12602
Conversation
🦋 Changeset detectedLatest commit: 9b55af0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This also need updates to a few sections in the docs: The new documentation where the mount/hydrate APIs are mentioned, and the "breaking changes in runes mode" section |
I don't think we need to add anything in 'breaking changes in runes mode', |
I'll add some docs real quick, one sec |
@@ -59,6 +61,8 @@ const app = hydrate(App, { | |||
}); | |||
``` | |||
|
|||
As with `mount`, effects will not run during `hydrate` — use `flushSync()` immediately afterwards if you need them to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you mirror that into the docs at documentation/...
? because those are the soon-to-be final docs
Attempt 2# at #12587. Fixes the SvelteKit issue by adding a
flush_sync
to the legacy wrapper.