Skip to content

fix: always synchronously call bind:this #12679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2024
Merged

fix: always synchronously call bind:this #12679

merged 1 commit into from
Jul 31, 2024

Conversation

dummdidumm
Copy link
Member

fixes #12673

#12591 wrongfully applied the "wrap in effect if an action on this element" logic for bind:this

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

fixes #12673

#12591 wrongfully applied the "wrap in effect if an action on this element" logic for `bind:this`
Copy link

changeset-bot bot commented Jul 31, 2024

🦋 Changeset detected

Latest commit: 484d8a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit 01e7845 into main Jul 31, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the bind-this-fix branch July 31, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bind:this is undefined when using an action
2 participants