-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
breaking: remove $state.link
callback
#12942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1a4008e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5 tasks
trueadm
approved these changes
Aug 20, 2024
Agreed 100% |
5 tasks
See also #12943 |
Releasing this pending resolution on the broader question of #12943 |
Rich-Harris
added a commit
that referenced
this pull request
Aug 21, 2024
This reverts commit 0b51ff0.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #12938 (comment) (and #12545 for the original PR).
I regretted this API almost as soon as I merged it. Short of removing
$state.link
altogether, I'm pretty certain that we should remove the callback version — if you need to do something more complicated than having a local piece of state immediately update when some other state changes, use an effect. Whether or not a dedicated API for the remaining use case (which is very narrow) is warranted is a live question, I think, but hopefully we can get agreement on this more limited change before too much damage is done from having the current version in the wild.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint