Skip to content

Stats #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 8, 2018
Merged

Stats #1299

merged 5 commits into from
Apr 8, 2018

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Apr 1, 2018

This is branched off of #1298. See #1257 for more info — for now, this just adds timings.

  • performance timings (done, but can still be fleshed out)
  • imports
  • used lifecycle hooks
  • used components
  • declared methods
  • expected data properties
  • computed properties
  • warnings

@codecov-io
Copy link

codecov-io commented Apr 1, 2018

Codecov Report

Merging #1299 into master will decrease coverage by 0.01%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1299      +/-   ##
==========================================
- Coverage   91.51%   91.49%   -0.02%     
==========================================
  Files         124      125       +1     
  Lines        4417     4467      +50     
  Branches     1390     1398       +8     
==========================================
+ Hits         4042     4087      +45     
- Misses        154      156       +2     
- Partials      221      224       +3
Impacted Files Coverage Δ
src/validate/index.ts 89.79% <ø> (ø) ⬆️
src/generators/Generator.ts 93.86% <100%> (+0.04%) ⬆️
src/generators/dom/index.ts 96.06% <100%> (ø) ⬆️
src/generators/server-side-rendering/index.ts 93.93% <100%> (ø) ⬆️
src/index.ts 88.4% <100%> (+2.19%) ⬆️
src/Stats.ts 86.11% <86.11%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c9d703...304a0e8. Read the comment docs.

@Rich-Harris
Copy link
Member Author

There are more things that could be added to stats, but on YAGNI grounds I'm going to leave it there for now — I have what I need to make the REPL changes I had in mind.

Adding things like expectedProperties and components will be beneficial when it comes to whole-app optimisation and discarding JS for non-interactive Sapper pages, but we can cross those bridges when we come to them. Removing the WIP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants