Skip to content

feat: add renderStaticHTML to render a component without hydration markers #14353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from

Conversation

paoloricciuti
Copy link
Member

@paoloricciuti paoloricciuti commented Nov 18, 2024

Closes #14337

we talked about this this afternoon with @trueadm ...for the moment this is just the implementation of rendering without hydration markers. I'll get to the "awaiting the the awaits" probably tomorrow (we also discussed about the possible implementation of that).

Just putting this up so it should be easier to focus on the await part later on.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Nov 18, 2024

🦋 Changeset detected

Latest commit: cc8093f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-14353-svelte.vercel.app/

this is an automated message

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@14353

@Rich-Harris
Copy link
Member

I don't think we should do this. The comments are harmless unless you're doing something really niche, in which case this is easily solved in userland.

@paoloricciuti
Copy link
Member Author

I don't think we should do this. The comments are harmless unless you're doing something really niche, in which case this is easily solved in userland.

Yeah we were talking about that with @trueadm just now...it's fine. I was almost done implementing the await of await blocks so i'll finish that up just for funzies and just so that we might have a reference implementation when and if we add something similar

@trueadm
Copy link
Contributor

trueadm commented Nov 19, 2024

I'm going to close this, as to not give people a false idea on new APIs coming. However, we should definitely keep it around as a future reference starting point.

@trueadm trueadm closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: render HTML without hydration
3 participants