-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat: attachments fromAction
utility
#15933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 5a18de2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Could this be achieved in user land too? |
Totally, in fact if we decide it's not good for core I'm gonna open a PR for runed |
So with this does the action run in effect still or preserved behavior of not running in effect? I tried migrating to using attachment but seems broken as mine was relying on being run server side or like pre? |
That's weird because actions don't run on the server either 😁 |
Where do actions run than? 🤔 |
On the client, as soon as an element is mounted |
Are attachments run the same way then? |
They are but are run within an effect so everything reactive you "pass" to them will make the attachment rerun |
Co-authored-by: Aidan Bleser <[email protected]>
This provides a way to convert from action to attachments...this is useful if you are using a library that provides actions (like melt) and you want to spread them in dumb components.
There's a slight type issue at the moment: if you have an optional argument to the action you will need to pass the second argument... I was not able to fix this yet but since I'm not sure if this will actually be merged I decided to put it out there to discuss and maybe someone better than me at TS will be able to fix it (or I'll fix it later since i have to go now)
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint