Skip to content

feat: attachments fromAction utility #15933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: attachments fromAction utility #15933

wants to merge 2 commits into from

Conversation

paoloricciuti
Copy link
Member

This provides a way to convert from action to attachments...this is useful if you are using a library that provides actions (like melt) and you want to spread them in dumb components.

<script>
	import Button from "./Button.svelte";
	import { log } from "log-my-number";
	import { fromAction } from "svelte/attachments";
	let count = $state(0);
</script>
<Button
	onclick={() => count++}
	{@attach fromAction(log, () => count)}
>
	{count}
</Button>

There's a slight type issue at the moment: if you have an optional argument to the action you will need to pass the second argument... I was not able to fix this yet but since I'm not sure if this will actually be merged I decided to put it out there to discuss and maybe someone better than me at TS will be able to fix it (or I'll fix it later since i have to go now)

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented May 15, 2025

🦋 Changeset detected

Latest commit: 5a18de2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15933

@JonathonRP
Copy link

Could this be achieved in user land too?

@paoloricciuti
Copy link
Member Author

Could this be achieved in user land too?

Totally, in fact if we decide it's not good for core I'm gonna open a PR for runed

@JonathonRP
Copy link

So with this does the action run in effect still or preserved behavior of not running in effect? I tried migrating to using attachment but seems broken as mine was relying on being run server side or like pre?

@paoloricciuti
Copy link
Member Author

So with this does the action run in effect still or preserved behavior of not running in effect? I tried migrating to using attachment but seems broken as mine was relying on being run server side or like pre?

That's weird because actions don't run on the server either 😁

@JonathonRP
Copy link

JonathonRP commented May 16, 2025

That's weird because actions don't run on the server either 😁

Where do actions run than? 🤔

@paoloricciuti
Copy link
Member Author

That's weird because actions don't run on the server either 😁

Where do actions run than? 🤔

On the client, as soon as an element is mounted

@JonathonRP
Copy link

On the client, as soon as an element is mounted

Are attachments run the same way then?

@paoloricciuti
Copy link
Member Author

They are but are run within an effect so everything reactive you "pass" to them will make the attachment rerun

Co-authored-by: Aidan Bleser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants