fix: ensure infinite effect loops are cleared after flushing #17601
+8
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #16746 we broke some behaviour around infinite effect loops, but due to a quirk of our test suite we didn't catch it.
This PR does two things — it augments the
effect-loop-infinitetest to ensure that the loop is cleared, and also adds aflushSyncafter the test logic runs, to ensure that nothing is 'left over' afterwards. This is also important for #16724, for reasons I don't yet totally grok.It does not yet fix the issue, hence draft status
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint