Skip to content

chore: remove SvelteKit data attributes from elements.d.ts#17613

Merged
Rich-Harris merged 2 commits intomainfrom
teemingc-patch-2
Feb 4, 2026
Merged

chore: remove SvelteKit data attributes from elements.d.ts#17613
Rich-Harris merged 2 commits intomainfrom
teemingc-patch-2

Conversation

@teemingc
Copy link
Member

@teemingc teemingc commented Feb 4, 2026

Apparently we were supposed to remove them after sveltejs/kit#11222 ? Is this a breaking change?

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Removed SvelteKit specific data attributes from elements.d.ts.
@changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2026

🦋 Changeset detected

Latest commit: ae4575f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

Playground

pnpm add https://pkg.pr.new/svelte@17613

@teemingc teemingc marked this pull request as ready for review February 4, 2026 08:56
@dummdidumm
Copy link
Member

Ah yeah we should be able to - can you check in a project just to be extra sure?

@teemingc
Copy link
Member Author

teemingc commented Feb 4, 2026

Yeah, it works the same as before. Shame that we can't do anything about sveltejs/kit#15229 yet

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for checking!

Removed SvelteKit data attributes from elements.d.ts.
@Rich-Harris Rich-Harris merged commit 05229d9 into main Feb 4, 2026
18 checks passed
@Rich-Harris Rich-Harris deleted the teemingc-patch-2 branch February 4, 2026 16:32
@github-actions github-actions bot mentioned this pull request Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants