Skip to content

Conversation

@Panya
Copy link
Contributor

@Panya Panya commented Mar 27, 2019

fixes #2290. I'm not sure that this is the right place to fix it, but all tests are green.

@codecov-io
Copy link

codecov-io commented Mar 28, 2019

Codecov Report

Merging #2327 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2327   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files           1        1           
  Lines          49       49           
=======================================
  Hits           45       45           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7877005...9d0794b. Read the comment docs.

@Rich-Harris
Copy link
Member

Thanks for the PR, and apologies for letting it sit for so long. Unfortunately this isn't the correct fix — it works for {obj.x} but fails for {identity(obj.x)} or any other non-member-expression expression that resolves to a mutable value. I've opened an alternative PR, and will close this in favour of that: #3394

@Panya Panya deleted the issue-2290 branch August 11, 2019 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

View is not updated after change Array inside Object

3 participants