Skip to content

handle destructure to a store value#5452

Merged
Conduitry merged 6 commits intosveltejs:masterfrom
tanhauhau:tanhauhau/gh-5449
Sep 24, 2020
Merged

handle destructure to a store value#5452
Conduitry merged 6 commits intosveltejs:masterfrom
tanhauhau:tanhauhau/gh-5449

Conversation

@tanhauhau
Copy link
Copy Markdown
Member

Fixes #5449

disabled the test for SSR, which will be fixed via #5419

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@Conduitry Conduitry mentioned this pull request Sep 24, 2020
4 tasks
@Conduitry Conduitry merged commit c3b56a1 into sveltejs:master Sep 24, 2020
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Destructuring into a store doesn't work since 3.26

2 participants