-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
make it possible to render svelte-components inside a shadow dom #5870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 30 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
3c172ae
implement 'stylesTarget'
ivanhofer 6be6652
fix tests for 'stylesTarget'
ivanhofer 53e92e2
add docs for 'stylesTarget'
ivanhofer 2b4358b
get styles target from target instead of its own option
ivanhofer d255b8d
pass options.target down to each create_fragment
ivanhofer 5111a79
remove `stylesTarget` from docs
ivanhofer 2ce0960
WIP: replace root with context reference
ivanhofer 7568a91
add root as compile option also in prod mode
ivanhofer a94abed
mark 'root' as special
ivanhofer 613b87d
store root information in component.$$.root
ivanhofer 6be2c2a
fix existing tests
ivanhofer bd90b1f
use `get_root_for_node` instead of `node.ownerDocument`
ivanhofer af3e164
split function `get_root_for_node` into `get_root_for_node` and `get_…
ivanhofer 0414ee6
test another append_styles approach
ivanhofer e5ecca3
only output `null` as value for `append_styles` in `init` function if…
ivanhofer e4a19d2
fix tests
ivanhofer 28e5e45
fix rebasing
ivanhofer eb6fd8f
fix SvelteComponentTyped constructor parmeter
ivanhofer accac63
docs
dummdidumm 7e5a1ec
fix `add_css` to allow custom stle hashes
ivanhofer 62224a5
Merge branch 'stylesTarget' of github.com:ivanhofer/svelte into style…
ivanhofer a1a0585
fix test
dummdidumm 5e0ece2
fix test
dummdidumm 82a20e4
fix test
dummdidumm f9528c0
fix test
dummdidumm 50fe25f
fix test
dummdidumm 4c4adeb
rename variables to snake_case
ivanhofer 3d41b6b
use `getElementById` to look for existing stylesheets
ivanhofer 11724dd
fix `append_empty_stylesheet`
ivanhofer 9c99c66
fix return of `append_empty_stylesheet`
ivanhofer c4a4024
tidy
Conduitry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -159,4 +159,4 @@ class Component extends SvelteComponent { | |
} | ||
} | ||
|
||
export default Component; | ||
export default Component; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.