-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[fix] propagate bindings correctly #8114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
<script> | ||
export let value; | ||
value = "bar"; | ||
</script> | ||
|
||
Child component "{value}"<br /> |
3 changes: 2 additions & 1 deletion
3
...ng-no-unnecessary-invalidation/_config.js → ...samples/binding-indirect-value/_config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,8 @@ | ||
export default { | ||
async test({ assert, target }) { | ||
assert.htmlEqual(target.innerHTML, ` | ||
<p>0</p> | ||
Parent component "bar"<br /> | ||
Child component "bar"<br /> | ||
`); | ||
} | ||
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<script> | ||
import Component from "./Component.svelte"; | ||
|
||
let value = "foo"; | ||
</script> | ||
|
||
Parent component "{value}"<br /> | ||
<Component bind:value /> |
File renamed without changes.
10 changes: 10 additions & 0 deletions
10
test/runtime/samples/binding-no-unnecessary-invalidation.skip/_config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
// this test currently fails because the fix that made it pass broke other tests, | ||
// see https://github.com/sveltejs/svelte/pull/8114 for more context. | ||
export default { | ||
skip: true, | ||
async test({ assert, target }) { | ||
assert.htmlEqual(target.innerHTML, ` | ||
<p>0</p> | ||
`); | ||
} | ||
}; |
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you tell an example that comes to the catch statement?
Is it intended to handle
Maximum call stack size exceeded
?Is there any possibility that this may cause the unintended DOM structure and the runtime to go wrong behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's on test that throws a runtime error (I believe some dev time check for svelte:element) and then all other tests afterwards fail because flush is in a broken state then. Yes, we could end up in a broken Dom state but at least the app might continue to work. The alternative would be to not do this but only do console.error in that check.