chore: remove node<14 tests#8482
Conversation
|
@dummdidumm is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
benmccann
left a comment
There was a problem hiding this comment.
I was going to ask if we should keep 12 for awhile longer, but 20 comes out next week and 14 is EOL at the end of the month, so I think supporting 14 still is generous enough
benmccann
left a comment
There was a problem hiding this comment.
lgtm, but will need to fix the test failures before merging
| chcp 65001 | ||
| echo ("NODE_VERSION=$(node --version)") >> $env:GITHUB_ENV | ||
| if: runner.os == 'Windows' | ||
| - run: npm install --save-dev puppeteer@13 |
There was a problem hiding this comment.
I think we would still need this, but I upgraded puppeteer so that it's no longer necessary and we can run the tests locally. I can reproduce the test failures locally, but have no clue why they're happening
|
Hmm. Maybe the test failures are related to some of the recently merged PRs. I see it expecting |
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests
npm testand lint the project withnpm run lint