Skip to content

Css preprocessing #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 3, 2017
Merged

Css preprocessing #969

merged 13 commits into from
Dec 3, 2017

Conversation

Rich-Harris
Copy link
Member

This builds atop #959 — a few tweaks here and there, but the biggest change is that it removes Pug, CoffeeScript etc, as it's not necessary to include those in order to test preprocess

@codecov-io
Copy link

codecov-io commented Dec 3, 2017

Codecov Report

Merging #969 into master will increase coverage by 0.02%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #969      +/-   ##
==========================================
+ Coverage   91.76%   91.78%   +0.02%     
==========================================
  Files         109      110       +1     
  Lines        4054     3980      -74     
  Branches     1301     1304       +3     
==========================================
- Hits         3720     3653      -67     
+ Misses        150      142       -8     
- Partials      184      185       +1
Impacted Files Coverage Δ
src/index.ts 86.2% <92.59%> (+4.95%) ⬆️
test/parser/index.js 100% <0%> (ø)
src/shared/utils.js 100% <0%> (+8.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72bd23a...b856ac2. Read the comment docs.

@Rich-Harris Rich-Harris merged commit fd77c40 into master Dec 3, 2017
@Rich-Harris Rich-Harris deleted the css-preprocessing branch December 3, 2017 14:04
@esarbanis
Copy link
Contributor

Oh, wow! I sure learnt a lot from this PR. Thanks for your time!

@Rich-Harris
Copy link
Member Author

No, thank you! It's great to finally have a solution to this problem. Release coming soon

sacrosanctic pushed a commit to sacrosanctic/svelte that referenced this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants