Fix gitignore #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

benmccann merged 2 commits into sveltejs:master from MarcusOtter:patch-1

May 3, 2021

Contributor

MarcusOtter commented May 3, 2021

Remove lock file gitignores

Reasons:

"Do I commit the package-lock.json file created by npm 5?" (https://stackoverflow.com/questions/39990017/should-i-commit-the-yarn-lock-file-and-what-is-it-for) and
"Should I commit the yarn.lock file?" (https://stackoverflow.com/questions/39990017/should-i-commit-the-yarn-lock-file-and-what-is-it-for)
The svelte rollup template does not have these files in the gitignore. https://github.com/sveltejs/template/blob/master/.gitignore

Fix gitignore build path

Reasons:

It was changed with use same file structure as svelte rollup template #34 and Update template to Webpack 5 for better experience #36 but the gitignore was forgotten.

MarcusOtter added 2 commits

May 3, 2021 12:40


          Remove lock file gitignores

3ce2df3

Sources:
- "Do I commit the package-lock.json file created by npm 5?" (https://stackoverflow.com/questions/39990017/should-i-commit-the-yarn-lock-file-and-what-is-it-for) and
- "Should I commit the yarn.lock file?" (https://stackoverflow.com/questions/39990017/should-i-commit-the-yarn-lock-file-and-what-is-it-for)
- The svelte rollup template which does not have these files in the gitignore. https://github.com/sveltejs/template/blob/master/.gitignore


          Fix gitignore build path

ca52643

It was changed as of #34 and #36 but the gitignore was never updated.

benmccann merged commit 45224d8 into sveltejs:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet