feat: default to hydratable: false and add dynamicCompileOptions#122
Merged
feat: default to hydratable: false and add dynamicCompileOptions#122
Conversation
rixo
reviewed
Jul 27, 2021
|
|
||
| This is done to align with svelte compiler defaults and improve output in non-ssr scenarios. | ||
|
|
||
| Add `{compilerOptions: {hydratable: true}}` to vite-plugin-svelte config if you need hydration (eg. for ssr) |
Collaborator
There was a problem hiding this comment.
Should mention that defaults to true when Vite options.ssr is true, no? Or isn't this the case?
Contributor
Author
There was a problem hiding this comment.
not the case as not all SSR solutions set that and I chose consistency over automatic default that only works some of the time
5 tasks
Contributor
Author
|
After sveltejs/kit#2024 has been merged and released, update kit version here and tests should pass. |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #120 and #121