Skip to content

chore: allow Vite 5 #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benmccann wants to merge 12 commits into from
Closed

chore: allow Vite 5 #817

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
63b28c4
chore: allow Vite 5
benmccann Nov 28, 2023
851153a
add vite 5 to CI
benmccann Nov 28, 2023
d7ebd5b
don't run vite 5 against node 14. it's too old
benmccann Nov 28, 2023
393a933
ensure we don't get vite 6
benmccann Nov 28, 2023
2fd4245
--no-frozen-lockfile
benmccann Nov 28, 2023
dd965cf
hmm
benmccann Nov 28, 2023
a33d639
skip import queries tests on vite 5
benmccann Nov 28, 2023
1613e22
fix: add browser to default resolve.mainFields (#809)
WoodyWoodsta Nov 21, 2023
b8549a1
test(vite-ssr): set manifest location per vite5 (#755)
dominikg Sep 18, 2023
2aaced2
skip cjs test on vite 5
benmccann Nov 28, 2023
407ca24
exclude browser from vite 4
benmccann Nov 28, 2023
6715542
update changeset
benmccann Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/e2e-tests/kit-node/__tests__/kit.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ describe('kit-node', () => {
);
expectArrayEqual(
config.resolve.mainFields,
['svelte', 'module', 'jsnext:main', 'jsnext'],
['svelte', 'browser', 'module', 'jsnext:main', 'jsnext'],
`resolve.mainFields in ${filename}`
);
expectArrayEqual(
Expand Down
2 changes: 1 addition & 1 deletion packages/vite-plugin-svelte/src/utils/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { isSvelte3 } from './svelte-version.js';

export const VITE_RESOLVE_MAIN_FIELDS = ['module', 'jsnext:main', 'jsnext'];
export const VITE_RESOLVE_MAIN_FIELDS = ['browser', 'module', 'jsnext:main', 'jsnext'];

export const SVELTE_RESOLVE_MAIN_FIELDS = ['svelte'];

Expand Down