Skip to content

Fix compiling on macOS Sierra/clang #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix compiling on macOS Sierra/clang #80

wants to merge 1 commit into from

Conversation

wendigo
Copy link

@wendigo wendigo commented Oct 6, 2016

Related to golang/go#17356

@ilovezfs
Copy link

I'm confused why this would be needed since I just shipped a Sierra bottle without issue:

Homebrew/homebrew-core#6184
Homebrew/homebrew-core@ad1bfc8
Homebrew/homebrew-core@e574d43

What am I not understanding? Was an alternative fix merged?

@svent
Copy link
Owner

svent commented Oct 23, 2016

This PR is not needed anymore as I completely removed the old C code.
Please see the comment on #81 for details.

@ilovezfs Thanks for updating sift on Homebrew!

@svent svent closed this Oct 23, 2016
@ilovezfs
Copy link

@svent you're welcome. I knew there must be an explanation!

@wendigo
Copy link
Author

wendigo commented Oct 31, 2016

@ilovezfs as @svent explained - this failed to compile on old version :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants