server: add case-preserving header map#2177
Merged
svix-jbrown merged 2 commits intomainfrom Feb 10, 2026
Merged
Conversation
svix-jbrown
force-pushed
the
jbrown/case-insensitive
branch
from
eb332ee to
32a4af2
Compare
svix-jplatte
previously approved these changes
Feb 10, 2026
server/svix-server/src/core/types/case_preserving_header_map.rs
Outdated
Show resolved
Hide resolved
server/svix-server/src/core/types/case_preserving_header_map.rs
Outdated
Show resolved
Hide resolved
server/svix-server/src/core/types/case_preserving_header_map.rs
Outdated
Show resolved
Hide resolved
server/svix-server/src/core/types/case_preserving_header_map.rs
Outdated
Show resolved
Hide resolved
svix-jplatte
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the OSS version of the server uses a simple
HashMap<String, String>for headers. This results in confusing behavior if the same header is inserted twice with different casings (for example, if a custom override header setsUser-Agent, and our code insertsuser-agent).This PR modifies the server to use a case preserving map for headers, which will still correctly remember the difference between
user-agentandUser-Agent, but will not allow duplicates.This is mostly migrated from svix/svix-webhooks-private#5916 in the private fork, with modifications to work with the OSS layout.
Part of svix/monorepo-private#12554