Skip to content

Add missing messageattempt index#2187

Merged
svix-james merged 1 commit intosvix:mainfrom
jaymell:message-attempt-per-endp-no-status
Feb 18, 2026
Merged

Add missing messageattempt index#2187
svix-james merged 1 commit intosvix:mainfrom
jaymell:message-attempt-per-endp-no-status

Conversation

@svix-james
Copy link
Contributor

Fixes #2183

@jaymell jaymell force-pushed the message-attempt-per-endp-no-status branch 2 times, most recently from d42f721 to 3c8794b Compare February 17, 2026 19:47
@svix-james svix-james marked this pull request as ready for review February 17, 2026 20:31
@svix-james svix-james requested a review from a team as a code owner February 17, 2026 20:31
svix-lucho
svix-lucho previously approved these changes Feb 17, 2026
@svix-jbrown
Copy link
Contributor

Are we worried about hitting the statement timeout in OSS releases?

@jaymell
Copy link
Contributor

jaymell commented Feb 17, 2026

Are we worried about hitting the statement timeout in OSS releases?

Yeah, it's a good point. I suppose we can completely disable timeouts for this command. Will require a custom migrator, though, as to my knowledge sqlx does not support multiple statements in a non-transactional migration.

@jaymell jaymell force-pushed the message-attempt-per-endp-no-status branch from caa963e to ada921d Compare February 17, 2026 23:17
@jaymell
Copy link
Contributor

jaymell commented Feb 17, 2026

Open Source Review

Added futures-util crate. Popular crate, we already use this elsewhere.

@svix-james svix-james merged commit b1a5dd2 into svix:main Feb 18, 2026
16 checks passed
@jaymell jaymell deleted the message-attempt-per-endp-no-status branch February 18, 2026 21:39
svix-james added a commit that referenced this pull request Feb 20, 2026
svix-james added a commit that referenced this pull request Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Index missing for messageattempt

4 participants