Support library template (sub-template); add jersey2 template for Java client #1046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for a specific language
xhh
changed the title
Conflicts: modules/swagger-codegen/src/main/resources/Java/ApiClient.mustache
Conflicts: modules/swagger-codegen/src/main/java/io/swagger/codegen/languages/JavaClientCodegen.java modules/swagger-codegen/src/main/resources/Java/api.mustache
|
ok wow. This does look good to me. I'll see about the conflicts and report back if i can't merge it |
Conflicts: modules/swagger-codegen/src/main/resources/Java/JsonUtil.mustache
|
@fehguy I've just fixed the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #950 for background and context of this PR.
Added a
libraryconfig option to specify the library template (sub-template) to be used$ java -jar modules/swagger-codegen-cli/target/swagger-codegen-cli.jar config-help -l java CONFIG OPTIONS ... library library template (sub-template) to use: <default> - HTTP client: Jersey client 1.18. JSON processing: Jackson 2.4.2 jersey2 - HTTP client: Jersey client 2.6Refactored
ApiClient#invokeAPIand JSON handling to make it easier to override underlying HTTP client and JSON processingAdded a
jersey2library template to generate Java client with jersey-client 2.6 instead of the default 1.18The jersey2 template is mainly from PR updated client to use jersey2, rebuilt samples #950 by @fehguy
@fehguy please have a look at this, and if you have any concerns (e.g. the naming of the
libraryoption), please comment and I'll revise accordingly