fix regex expression prone to backtracking in JavaClientCodegen #12647
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewaostrowska
approved these changes
Nov 3, 2025
| final private static Pattern JSON_MIME_PATTERN = Pattern.compile("(?i)application\\/json(;.*)?"); | ||
| final private static Pattern JSON_VENDOR_MIME_PATTERN = Pattern.compile("(?i)application\\/vnd.(.*)+json(;.*)?"); | ||
| private static final Pattern JSON_MIME_PATTERN = Pattern.compile("(?i)application/json(;.*)?"); | ||
| private static final Pattern JSON_VENDOR_MIME_PATTERN = Pattern.compile("(?i)application/vnd\\..*\\+json(;.*)?"); |
Contributor
There was a problem hiding this comment.
Any tests or they already exist?
Member
Author
There was a problem hiding this comment.
They do, in JavaClientCodegenTest.
daniel-kmiecik
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.