[PHP] addd binary support to response and body parameter #1891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
force-pushed
the
php_binary_support
branch
from
7915a65 to
fee8ace
Compare
wing328
added a commit
that referenced
this pull request
Jan 15, 2016
[PHP] addd binary support to response and body parameter
| @@ -241,6 +241,8 @@ class ObjectSerializer | |||
| $values[] = $this->deserialize($value, $subClass); | |||
| } | |||
| $deserialized = $values; | |||
| } elseif ($class === 'ByteArray') { // byte array | |||
| $deserialized = unpack('C*', (string)$data); | |||
There was a problem hiding this comment.
I realize the mapped type is a technically a byte array but this seems more natural to return as a string. Even printing this data is complicated as it's an array of integers and PHP's pack cannot be called with an Array.
$string = "";
foreach($deserialized as $int) {
$string = $string . pack("C", $int);
}Compare with string returned:
echo $deserialized;File operations also don't support this unpacked format either.
There was a problem hiding this comment.
Here is a 1-liner to restore the byte array: https://github.com/swagger-api/swagger-codegen/blob/master/samples/client/petstore/php/SwaggerClient-php/tests/PetApiTest.php#L329
Agree that it's not straightforward but that's how PHP represents byte array.
Ref: http://stackoverflow.com/questions/885597/string-to-byte-array-in-php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPUnit 4.7.2 by Sebastian Bergmann and contributors.
....................
Time: 14.33 seconds, Memory: 18.00Mb
OK (20 tests, 3074 assertions)